Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4634 +/- ##
==========================================
- Coverage 9.86% 9.69% -0.18%
Complexity 265 265
==========================================
Files 124 126 +2
Lines 6173 6324 +151
Branches 1423 1181 -242
==========================================
+ Hits 609 613 +4
- Misses 5441 5590 +149
+ Partials 123 121 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (version === '4.0') { | ||
| contact.vCard.addPropertyWithValue('rev', ICAL.Time.fromJSDate(new Date(), true)) | ||
| } | ||
| if (version === '3.0') { |
There was a problem hiding this comment.
I think we should alter the condition here. I think this needs to also accommodate, prior versions, as this logic would break down if someone has a card with a lower version. Idk, if it's worth it tho, bring it up tomorrow, lets see what the team thinks
There was a problem hiding this comment.
No other versions are supported but let's leave it for the call
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
|
/backport to stable7.2 |
|
/backport to stable7.3 |
|
I think there still is an issue with this merge request unfortunatly. |
4 participants
depends on nextcloud/server#54573